Skip to content

Add OnDataLoaded EventCallback#8675

Merged
michaelstaib merged 8 commits into
ChilliCream:mainfrom
behroozbc:main
Sep 30, 2025
Merged

Add OnDataLoaded EventCallback#8675
michaelstaib merged 8 commits into
ChilliCream:mainfrom
behroozbc:main

Conversation

@behroozbc
Copy link
Copy Markdown
Contributor

Summary of the changes (Less than 80 chars)

  • Add OnDataLoaded EventCallback on UseQueryCompoent of blazor

I couldn’t test this because every time I tried to add it to my Blazor project, I got other errors that weren’t related at all.
But based on my experience, I think this is correct.
Please test it if possible.
Also, I couldn’t find UseQuery component tests and didn’t write them. If needed, please guide me.
Additionally, I have a complaint about CONTRIBUTING.md because the information is outdated!
Closes #8673

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 5, 2025

CLA assistant check
All committers have signed the CLA.

@michaelstaib michaelstaib marked this pull request as draft September 17, 2025 09:24
@glen-84 glen-84 self-requested a review September 17, 2025 09:37
@behroozbc
Copy link
Copy Markdown
Contributor Author

I see @glen-84 you want to review this pull requests, how I can help you to this PR be merge sooner?

@michaelstaib
Copy link
Copy Markdown
Member

We have put the PR on our internal backlog for discussion @glen-84 will review the actual issue and then we will see what design will fit to your issue.

Comment thread src/StrawberryShake/Client/src/Razor/UseQuery.cs Outdated
Comment thread src/StrawberryShake/Client/src/Razor/UseQuery.cs Outdated
Comment thread src/StrawberryShake/Client/src/Razor/UseQuery.cs
@behroozbc behroozbc requested a review from glen-84 September 22, 2025 13:01
@behroozbc
Copy link
Copy Markdown
Contributor Author

I think this have be on another pull request.
I saw the use query and use subscription have many same things, I like to know why these two classes cannot inheritance from same class, for example componentbase-> UseBase class( this name must change)-> usequery, usesubscription.

@glen-84
Copy link
Copy Markdown
Member

glen-84 commented Sep 24, 2025

LGTM, I'm just waiting for @michaelstaib to comment on the testing aspect.

@michaelstaib michaelstaib marked this pull request as ready for review September 30, 2025 12:31
@michaelstaib michaelstaib merged commit c2f8a94 into ChilliCream:main Sep 30, 2025
3 checks passed
@michaelstaib
Copy link
Copy Markdown
Member

michaelstaib commented Sep 30, 2025

I will create a preview this week and ping you once its available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OnDataLoad Event on UseQuery blazor

4 participants