Update RabbitMQ.Client to version 7.0.0

[ittennull]

Summary of the changes (Less than 80 chars)

• Update RabbitMQ.Client to version 7.0.0
• Refactor topic implementations to always use IAsyncDisposable

Closes #8381

Old version of RabbitMQ.Client creates runtime errors if a projects uses 7.* version of RabbitMQ.Client or any dependency that rely on it, for example Masstransit

[CLAassistant]

All committers have signed the CLA.

[tobias-tengler]

Thank you for the contribution @ittennull :)

Some tests are still failing. It would be great if you could get them to pass.

[ittennull]

I fixed one test but all the RabbitMQ tests are red because the test library Squadron.RabbitMQ also uses outdated RMQ client which is not compatible with the new version. They don't have an update for it yet.
I ran the tests with RMQ running on localhost (I replaced connection values in test) and everything was green. However, I understand that it's not sufficient.
Maybe we can look into NOT using Squadron for RMQ?

[Copilot]

Pull Request Overview

This PR updates the RabbitMQ.Client package from version 6.4.0 to 7.1.2 and refactors the topic implementations to consistently use IAsyncDisposable instead of IDisposable for better asynchronous resource management.

• Updates RabbitMQ.Client to version 7.1.2 for compatibility with projects using newer versions
• Refactors all topic implementations to use IAsyncDisposable pattern throughout the codebase
• Migrates RabbitMQ test infrastructure from Squadron to Testcontainers

Reviewed Changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
Directory.Packages.props	Updates RabbitMQ.Client to 7.1.2 and adds Testcontainers packages
DefaultTopic.cs	Changes session handling to use IAsyncDisposable instead of IDisposable
DefaultPubSub.cs	Adds IsDisposed property for disposal state tracking
RabbitMQTopic.cs	Major refactor to use async RabbitMQ.Client 7.x APIs and IAsyncDisposable
RabbitMQConnection.cs	Complete rewrite to use async connection APIs and proper resource management
PostgresTopic.cs	Updates to return IAsyncDisposable from OnConnectAsync
NatsTopic.cs	Updates Session class to implement IAsyncDisposable
RedisTopic.cs	Removes synchronous Dispose method, keeping only async disposal
Test files	Updates test infrastructure and fixes disposal patterns

Files not reviewed (1)

• src/HotChocolate/Core/src/Subscriptions.RabbitMQ/Properties/RabbitMQResources.Designer.cs: Language not supported

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[tobias-tengler]

Thanks for fixing up the tests!
I like the switch to Testcontainers, but I'll check with the team first to confirm there wasn't a specific reason we chose Squadron originally.

[ittennull]

I'll check with the team first to confirm there wasn't a specific reason we chose Squadron originally.

TestContainers work better here because the package only starts and stops containers and it doesn't depend on RabbitMq.Client library at all, so it's safer for any future updates

[ittennull]

I'll check with the team first to confirm there wasn't a specific reason we chose Squadron originally.

@tobias-tengler Hi, did you have a chance to confer with the team yet?

[tobias-tengler]

@ittennull Yes, we're going to stick with Squadron for now.
We just released a new version that should be compatible: https://github.com/SwissLife-OSS/squadron/releases/tag/0.26.0
Could you please undo your TestContainer changes and update to that Squadron version instead?

Also, please downgrade RabbitMQ.Client to just 7.0.0. We do not want to force people to use a specific minor/patch version.

[ittennull]

OK, will do. The update of Squadron failed though

[ittennull]

I saw that you updated Squadron to support RMQ 7 but the build fails because of the build scripts. I created a PR to fix it but nobody reviews it. I even wrote an email to the person who created these build scripts - no response.
I'm not sure if Squadron is a good dependency, in 6 years there are 100 commits, no updates, the github insights shows that the project is practically dead, the authors don't review PRs. Perhaps for the sake of hotchocolate you guys can re-consider if moving to another testing library is beter

[tobias-tengler]

@ittennull Good catch with the .slnx. I'll just undo my change to the solution file in the Squadron repository. Let's hope this fixes the issue.
In the short term @michaelstaib wants to move Squadron to this repository, as it was primarily built as test tooling for Hot Chocolate. This would also get rid of dependency issues like this.
Sorry for the delay here!

[tobias-tengler]

@ittennull Squadron v26.0.0 is now available :)

[ittennull]

@tobias-tengler I updated the package. Could you approve the workflow and check the PR again?

[tobias-tengler]

@ittennull Looks good! :) I just have couple of questions.

[ittennull]

I also marked the queue as auto-delete because I noticed that we have thousands of messages and queues lying around with zero consumers. That happens when a graphql subscription finishes and a consumer unsubscribes. A queue is exclusive and isn't deleted because the connection that created it still lives and serves other new queues. So the only way to clean RMQ memory and storage is to restart your app

[tobias-tengler]

@ittennull Thanks for addressing my questions and thanks again for your time / contribution :)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (8cd58f7) to head (f8c1b5d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@     Coverage Diff      @@
##   main   #8797   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.