Fix stackalloc buffer size to use required byte count#9168
Merged
michaelstaib merged 6 commits intoFeb 20, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix a buffer allocation bug in UTF-8 encoding where stackalloc was incorrectly using value.Length (character count) instead of requiredBytes (actual UTF-8 byte count). This could cause buffer overflow when encoding strings with multi-byte UTF-8 characters.
Changes:
- Fixed stackalloc buffer size in
SetStringValue(ReadOnlySpan<char>)to userequiredBytesinstead ofvalue.Length
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michaelstaib
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
michaelstaib
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an incorrect buffer allocation in the UTF-8 encoding path where stackalloc was using value.Length instead of the computed requiredBytes.