Skip to content

[MCP] Improve namespaces#9657

Merged
glen-84 merged 3 commits into
mainfrom
gai/mcp-namespaces
May 8, 2026
Merged

[MCP] Improve namespaces#9657
glen-84 merged 3 commits into
mainfrom
gai/mcp-namespaces

Conversation

@glen-84
Copy link
Copy Markdown
Member

@glen-84 glen-84 commented May 8, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 8, 2026 14:20
@github-actions github-actions Bot added 📚 documentation This issue is about working on our documentation. 🌶️ hot chocolate labels May 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts namespaces for MCP adapter extension methods to reduce the need for extra using directives and to align entry points with commonly imported namespaces (e.g., Microsoft.Extensions.DependencyInjection, HotChocolate, HotChocolate.Types).

Changes:

  • Move MCP extension method containers into more commonly used namespaces (DI, HotChocolate, and HotChocolate.Types).
  • Update docs/tests to remove now-unnecessary using HotChocolate.Adapters.Mcp.Extensions;.
  • Rename the object-field descriptor extension container to avoid a name collision in HotChocolate.Types.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
website/src/docs/hotchocolate/v16/guides/mcp-adapter.md Updates docs snippet to reflect the new extension method namespace.
src/HotChocolate/Adapters/test/Adapters.Mcp.Tests/OperationToolFactoryTests.cs Removes now-unnecessary using for MCP extensions.
src/HotChocolate/Adapters/src/Fusion.Adapters.Mcp/Extensions/FusionGatewayBuilderExtensions.cs Moves Fusion MCP gateway extensions into Microsoft.Extensions.DependencyInjection.
src/HotChocolate/Adapters/src/Adapters.Mcp/Extensions/SchemaBuilderExtensions.cs Moves schema builder extension into HotChocolate namespace.
src/HotChocolate/Adapters/src/Adapters.Mcp/Extensions/ObjectFieldDescriptorExtensions.cs Moves field-descriptor extension into HotChocolate.Types and renames the class to avoid collisions.
src/HotChocolate/Adapters/src/Adapters.Mcp.Core/Extensions/ServiceCollectionExtensions.cs Removes an unused using.
Comments suppressed due to low confidence (1)

src/HotChocolate/Adapters/src/Adapters.Mcp/Extensions/SchemaBuilderExtensions.cs:8

  • The new namespace change makes this type HotChocolate.SchemaBuilderExtensions, which already exists in the core library (e.g. src/HotChocolate/Core/src/Types/Extensions/SchemaBuilderExtensions.Types.cs:11). Having two public types with the same fully-qualified name across referenced assemblies will cause ambiguous type resolution for consumers that reference SchemaBuilderExtensions directly (e.g. SchemaBuilderExtensions.AddQueryType(...)). Consider renaming this class (e.g. McpSchemaBuilderExtensions) while keeping the HotChocolate namespace, or moving it to a non-conflicting namespace.
// ReSharper disable once CheckNamespace
namespace HotChocolate;

public static class SchemaBuilderExtensions
{
    public static ISchemaBuilder AddMcp(this ISchemaBuilder builder)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@glen-84 glen-84 merged commit 92e1c90 into main May 8, 2026
137 of 138 checks passed
@glen-84 glen-84 deleted the gai/mcp-namespaces branch May 8, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 documentation This issue is about working on our documentation. 🌶️ hot chocolate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants