[MCP] Make storage observer resilient to duplicates and bad documents#9673
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the MCP adapter’s storage observer initialization to tolerate duplicate prompt/tool names (instead of throwing on duplicate dictionary keys), and adds integration tests to ensure listing prompts/tools no longer crashes when duplicates exist.
Changes:
- Deduplicate prompt definitions by name during
McpStorageObserverinitialization. - Deduplicate tool definitions by name during
McpStorageObserverinitialization. - Add a test-only
IMcpStorageimplementation that can return duplicate definitions, plus new integration tests covering the duplicate-name scenarios.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/HotChocolate/Adapters/src/Adapters.Mcp.Core/McpStorageObserver.cs | Deduplicates prompt/tool definitions during initial load to avoid crashing on duplicate names. |
| src/HotChocolate/Adapters/test/Adapters.Mcp.Tests/MultiCollectionMcpStorage.cs | Adds a test IMcpStorage implementation that returns definitions verbatim (including duplicates). |
| src/HotChocolate/Adapters/test/Adapters.Mcp.Tests/IntegrationTestBase.cs | Adds integration tests asserting duplicates are deduped and list operations don’t crash. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
glen-84
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- src/HotChocolate/Adapters/src/Adapters.Mcp.Abstractions/Properties/McpAdapterResources.Designer.cs: Language not supported
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- src/HotChocolate/Adapters/src/Adapters.Mcp.Abstractions/Properties/McpAdapterResources.Designer.cs: Language not supported
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- src/HotChocolate/Adapters/src/Adapters.Mcp.Abstractions/Properties/McpAdapterResources.Designer.cs: Language not supported
This was referenced May 13, 2026
This was referenced May 16, 2026
Closed
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.