[OpenAPI] Prefer valid duplicate over invalid when deduping endpoints#9681
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates OpenAPI endpoint deduplication so that when multiple endpoint definitions share the same (HTTP method, route), a later valid endpoint can be preferred over an earlier invalid one, preventing a broken endpoint from “winning” just because it appears first.
Changes:
- Update endpoint selection logic in
OpenApiDefinitionRegistryto prefer descriptors with a valid document when deduping by(method, route). - Expose factory helpers to construct endpoint descriptors separately from ASP.NET endpoint wrapping (to support the new dedupe flow).
- Add an integration test + snapshot to cover “first invalid, second valid” duplicate route behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/HotChocolate/Adapters/test/Adapters.OpenApi.Tests/Endpoints/HttpEndpointIntegrationTestBase.cs |
Adds coverage ensuring duplicate routes prefer the valid definition over an invalid one. |
src/HotChocolate/Adapters/test/Adapters.OpenApi.Tests/Endpoints/__snapshots__/HttpEndpointIntegrationTestBase.Duplicated_Routes_FirstInvalidSecondValid_PrefersValid.snap |
Snapshot asserting the valid endpoint is selected (HTTP 200 + expected body). |
src/HotChocolate/Adapters/src/Adapters.OpenApi.Core/OpenApiDefinitionRegistry.cs |
Implements new dedupe strategy based on descriptor validation outcome. |
src/HotChocolate/Adapters/src/Adapters.OpenApi.Core/Execution/OpenApiEndpointFactory.cs |
Makes descriptor/endpoint construction helpers callable from the registry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 13, 2026
Open
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.