Remove npm dist-tag from release.yml#9689
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Nitro npm publishing steps in the release workflow to stop applying additional npm dist-tags after publishing, leaving each publish to use only the single --tag selected by release context.
Changes:
- Removed
PKGenv vars used only fornpm dist-tag add. - Removed
SECONDARY_BANDlogic that added an extra dist-tag (e.g.,latest-<major>) after publish. - Simplified publish steps to only run
npm publish --tag "$PRIMARY_BAND".
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:540
- Same tagging change here: for the highest stable major, the workflow now publishes only under
latestand no longer applies alatest-${MAJOR}dist-tag. Please confirm this is intended; otherwise, reintroduce a second tag step or change the publish tag so major-specific installs keep working.
# Pick the band this release publishes under, based on release context.
if [[ "$IS_HIGHEST_STABLE_MAJOR" == "true" ]]; then
PRIMARY_BAND="latest"
elif [[ "$IS_STABLE" == "true" ]]; then
PRIMARY_BAND="latest-${MAJOR}"
elif [[ "$GIT_TAG" =~ -rc\. ]]; then
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
439
to
444
| # Pick the band this release publishes under, based on release context. | ||
| if [[ "$IS_HIGHEST_STABLE_MAJOR" == "true" ]]; then | ||
| PRIMARY_BAND="latest" | ||
| SECONDARY_BAND="latest-${MAJOR}" | ||
| elif [[ "$IS_STABLE" == "true" ]]; then | ||
| PRIMARY_BAND="latest-${MAJOR}" | ||
| SECONDARY_BAND="" | ||
| elif [[ "$GIT_TAG" =~ -rc\. ]]; then |
This was referenced May 13, 2026
Closed
This was referenced May 21, 2026
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.