Skip to content

Remove npm dist-tag from release.yml#9689

Merged
tobias-tengler merged 1 commit into
mainfrom
tte/remove-npm-dist-tag
May 12, 2026
Merged

Remove npm dist-tag from release.yml#9689
tobias-tengler merged 1 commit into
mainfrom
tte/remove-npm-dist-tag

Conversation

@tobias-tengler
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 12, 2026 19:24
@tobias-tengler tobias-tengler merged commit b8bc57a into main May 12, 2026
16 checks passed
@tobias-tengler tobias-tengler deleted the tte/remove-npm-dist-tag branch May 12, 2026 19:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Nitro npm publishing steps in the release workflow to stop applying additional npm dist-tags after publishing, leaving each publish to use only the single --tag selected by release context.

Changes:

  • Removed PKG env vars used only for npm dist-tag add.
  • Removed SECONDARY_BAND logic that added an extra dist-tag (e.g., latest-<major>) after publish.
  • Simplified publish steps to only run npm publish --tag "$PRIMARY_BAND".
Comments suppressed due to low confidence (1)

.github/workflows/release.yml:540

  • Same tagging change here: for the highest stable major, the workflow now publishes only under latest and no longer applies a latest-${MAJOR} dist-tag. Please confirm this is intended; otherwise, reintroduce a second tag step or change the publish tag so major-specific installs keep working.
          # Pick the band this release publishes under, based on release context.
          if [[ "$IS_HIGHEST_STABLE_MAJOR" == "true" ]]; then
            PRIMARY_BAND="latest"
          elif [[ "$IS_STABLE" == "true" ]]; then
            PRIMARY_BAND="latest-${MAJOR}"
          elif [[ "$GIT_TAG" =~ -rc\. ]]; then

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 439 to 444
# Pick the band this release publishes under, based on release context.
if [[ "$IS_HIGHEST_STABLE_MAJOR" == "true" ]]; then
PRIMARY_BAND="latest"
SECONDARY_BAND="latest-${MAJOR}"
elif [[ "$IS_STABLE" == "true" ]]; then
PRIMARY_BAND="latest-${MAJOR}"
SECONDARY_BAND=""
elif [[ "$GIT_TAG" =~ -rc\. ]]; then
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants