Add cookie consent banner#9712
Merged
Merged
Conversation
The "Got it!" cookie notice is being replaced by a real CMP, and the workshop promo popup is unused. Cleans up the unused showPromo state along with it. Workshop redux state is kept since header and training page still consume it.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy cookie consent banner and the workshop promo banner from the website UI and Redux state, simplifying the site layout and common state management.
Changes:
- Removed
showPromofromCommonState, plus the relatedshowPromo/hidePromoactions and reducer handlers. - Deleted the
PromoandCookieConsentcomponents and removed their exports/usages. - Updated the site layout to no longer render the removed banners.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
website/src/state/common/common.state.ts |
Removes showPromo from the common Redux state shape and initial state. |
website/src/state/common/common.reducer.ts |
Removes reducer handlers for promo show/hide actions. |
website/src/state/common/common.actions.ts |
Removes promo-related Redux actions. |
website/src/components/misc/promo.tsx |
Deletes the promo banner component implementation. |
website/src/components/misc/index.ts |
Removes exports for the deleted CookieConsent and Promo components. |
website/src/components/misc/cookie-consent.tsx |
Deletes the cookie consent banner component implementation. |
website/src/components/layout/site/site-layout.tsx |
Stops rendering CookieConsent and Promo in the site layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michaelstaib
changed the title
This was referenced May 20, 2026
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.