Fix AllowNonPersistedOperation to preserve existing override fields#9726
Merged
Conversation
The extension previously contained a no-op if/else where both branches allocated a fresh PersistedOperationRequestOverrides, discarding any existing override state. Replace with a branch that constructs a new record when none exists and uses `with` to flip the flag otherwise.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates persisted operation request override handling so existing override records are preserved when enabling non-persisted operations.
Changes:
- Uses a
withexpression to updateAllowNonPersistedOperationon an existingPersistedOperationRequestOverridesinstance. - Keeps creation of a new override record only for the no-existing-options case.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 20, 2026
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension previously contained a no-op if/else where both branches allocated a fresh PersistedOperationRequestOverrides, discarding any existing override state. Replace with a branch that constructs a new record when none exists and uses
withto flip the flag otherwise.