Fix source generator emitting enum members as numeric values#9727
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bug in the Types.Analyzers source generator where enum-typed attribute arguments were emitted as EnumType.<numericValue> (e.g., Visibility.1), producing invalid C#. The new helper resolves the numeric value back to a named enum member, falling back to a numeric cast ((EnumType)value) when no single member matches (e.g., bitwise combinations of [Flags] values).
Changes:
- Introduce
FormatEnumConstantthat looks up enum field names by their constant value. - Replace the inline enum formatting in
FormatTypedConstantwith a call to the new helper. - Add an analyzer test plus snapshot covering enum and
[Flags]enum arguments on a custom attribute applied to a resolver parameter.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/TypeFileBuilderBase.cs | Resolves enum constants to their member names; falls back to numeric cast. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/ObjectTypeTests.cs | New test verifying generation for enum and [Flags] attribute arguments. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.CustomAttribute_With_Enum_And_Flags_Arguments_On_Parameter_MatchesSnapshot.md | New snapshot demonstrating the corrected emission (enum members by name, flags combination as (Enum)3). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.