[Analyzer] Fix Source Generator Connection type collision#9734
Merged
tobias-tengler merged 1 commit intoMay 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Source Generator–introduced connection type collision by aligning FactoryTypeReference.GetHashCode with its Equals implementation. Previously Equals used SyntaxComparer.BySyntax for TypeStructure but GetHashCode relied on the default reference-based hash of ITypeNode, so semantically equal type references hashed differently and connection type deduplication failed.
Changes:
- Use
SyntaxComparer.BySyntax.GetHashCode(TypeStructure)inFactoryTypeReference.GetHashCodeto matchEquals. - Add integration test fixtures (
GetBooks,GetFavoriteBooks) exercising two paginated fields over the same element type. - Add new schema snapshot test
Schema_Snapshot_Without_ConnectionName_Inferenceand update existing snapshot to cover both inferred and non-inferred connection naming.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Core/src/Types/Types/Descriptors/TypeReferences/FactoryTypeReference.cs | Make GetHashCode consistent with Equals via SyntaxComparer.BySyntax. |
| src/HotChocolate/Core/test/Types.Analyzers.Integration.Tests/Product.cs | Add two [UsePaging] queries over IEnumerable<Book> to reproduce the collision. |
| src/HotChocolate/Core/test/Types.Analyzers.Integration.Tests/IntegrationTests.cs | Add snapshot test with InferConnectionNameFromField = false. |
| .../snapshots/IntegrationTests.Schema_Snapshot.snap | Updated snapshot now includes distinct BooksConnection/FavoriteBooksConnection. |
| .../snapshots/IntegrationTests.Schema_Snapshot_Without_ConnectionName_Inference.snap | New snapshot showing both fields share a single BookConnection when inference is off. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.