[Nitro CLI] Respect NITRO_CLOUD_URL environment variable#9738
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Nitro CLI so the NITRO_CLOUD_URL environment variable is respected for the --cloud-url option, taking precedence over the session URL (but not over an explicit --cloud-url argument). Previously the option's default was hard-coded to Constants.ApiUrl, which meant the session URL was always preferred over the env var.
Changes:
- Remove the hard-coded default value from
OptionalCloudUrlOption, relying onNitroClientContext.Configureto fall back toConstants.ApiUrlwhen no URL is provided. - Simplify
ConfigureClientContextto use the option's resolved value (explicit arg or env var) and only fall back to the session URL when it's empty. - Update help-text snapshots across all command tests (remove
[default: api.chillicream.com]) and add newGlobalOptionsTestscases covering the new precedence rules.
Reviewed changes
Copilot reviewed 66 out of 66 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Nitro/CommandLine/src/CommandLine/Options/OptionalCloudUrlOption.cs | Drop hard-coded default so env var isn't masked. |
| src/Nitro/CommandLine/src/CommandLine/Extensions/RootCommandExtensions.cs | Simplified URL resolution preferring option value (explicit/env) over session. |
| src/Nitro/CommandLine/test/CommandLine.Tests/GlobalOptionsTests.cs | New tests covering env vs session vs explicit --cloud-url precedence. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/**/*.cs | Updated help-text snapshots to drop [default: api.chillicream.com]. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 20, 2026
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.