Fix projection of underlying ResolveWith member#9742
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression where ResolveWith<T> on a field that shadows a runtime member of the parent type stopped projecting that underlying member, causing [UseProjection] parents to populate an empty/null member that the custom resolver then sees instead of the real data.
Changes:
- Adds a new
CoreFieldFlags.MemberReplacementflag set byObjectFieldDescriptor.ResolveWithInternalwhenever a fluentResolveWithoverrides an existingMember. - Updates the queryable projection handler and the
SelectionExpressionBuilder(used byAsSelector) to keep projecting the underlying member when this flag is present. - Adds tests covering both
[UseProjection]andISelection.AsSelector<T>()paths.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Core/src/Types/Types/Descriptors/Configurations/CoreFieldFlags.cs | Adds MemberReplacement flag (1L << 34). |
| src/HotChocolate/Core/src/Types/Types/Descriptors/ObjectFieldDescriptor.cs | Sets MemberReplacement when ResolveWith shadows an existing member. |
| src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionHandlerBase.cs | Treats member-replacement fields as projectable in CanProjectMember. |
| src/HotChocolate/Core/src/Execution.Projections/SelectionExpressionBuilder.cs | Includes member-replacement fields when building AsSelector projections; small readability refactor. |
| src/HotChocolate/Data/test/Data.Tests/ResolveWithProjectionTests.cs | New tests covering [UseProjection] and AsSelector paths for shadowed ResolveWith. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 20, 2026
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9741