Fix schema settings serialization during export#9744
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the JSON serialization behavior of the schema *-settings.json file during schema export, ensuring certain characters (e.g., </>) are preserved in their unescaped form when rewriting an existing settings file.
Changes:
- Introduce shared
JsonWriterOptionsfor settings file writing withJavaScriptEncoder.UnsafeRelaxedJsonEscaping. - Use the shared writer options in both “update existing settings file” and “create new settings file” code paths.
- Add a regression test ensuring angle brackets remain unescaped after updating an existing settings file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/HotChocolate/Core/src/Types/Execution/Internal/SchemaFileExporter.cs |
Reuses a shared Utf8JsonWriter configuration to preserve unescaped characters when writing settings JSON. |
src/HotChocolate/AspNetCore/test/AspNetCore.CommandLine.Tests/SchemaExportCommandTests.cs |
Adds a regression test verifying angle brackets are preserved when an existing settings file is updated. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.