Introduce DesktopControlLease and integrate#14
Merged
Conversation
Replace the single-instance guard with a DesktopControlLease that coordinates exclusive desktop-control actions while allowing multiple MCP processes per session. Add DesktopControlLease implementation, wire it into ComputerRunToolRuntime (including test helpers Configure/ReplaceControlLeaseForTests), and use BeginDesktopControlInvocation/InvokeControl for input-changing tools in ComputerRunTools. Update ComputerRunLifecycleOptions to expose control lock and lease duration (with defaults and env/config mappings), update Program to configure the lease from options, and remove SingleInstanceGuard. Tests updated/expanded: new RuntimeMutationLock for serializing runtime mutations, new DesktopControlLease-focused tests and service stubs, and adjustments to integration tests to use test leases. README updated to document the control lease behavior, new env vars (CODEX_COMPUTER_RUN_CONTROL_LOCK, CODEX_COMPUTER_RUN_CONTROL_LEASE_SECONDS), and test coverage counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the single-instance guard with a DesktopControlLease that coordinates exclusive desktop-control actions while allowing multiple MCP processes per session.
Add DesktopControlLease implementation, wire it into ComputerRunToolRuntime (including test helpers Configure/ReplaceControlLeaseForTests), and use BeginDesktopControlInvocation/InvokeControl for input-changing tools in ComputerRunTools.
Update ComputerRunLifecycleOptions to expose control lock and lease duration (with defaults and env/config mappings), update Program to configure the lease from options, and remove SingleInstanceGuard.
Tests updated/expanded: new RuntimeMutationLock for serializing runtime mutations, new DesktopControlLease-focused tests and service stubs, and adjustments to integration tests to use test leases.
README updated to document the control lease behavior, new env vars (CODEX_COMPUTER_RUN_CONTROL_LOCK, CODEX_COMPUTER_RUN_CONTROL_LEASE_SECONDS), and test coverage counts.