Skip to content

use DOCKER_HOST to set the bind mount#180

Merged
ChristopherHX merged 1 commit into
mainfrom
derive-mount-from-env
Jun 2, 2024
Merged

use DOCKER_HOST to set the bind mount#180
ChristopherHX merged 1 commit into
mainfrom
derive-mount-from-env

Conversation

@ChristopherHX

Copy link
Copy Markdown
Owner

No description provided.

@ChristopherHX

Copy link
Copy Markdown
Owner Author

CC @igagis DOCKER_HOST should no longer use the hardcoded unix socket

it's all about internal settings of nektos/act that were not exposed

@ChristopherHX ChristopherHX merged commit cf74581 into main Jun 2, 2024
@ChristopherHX ChristopherHX deleted the derive-mount-from-env branch June 2, 2024 19:12
@igagis

igagis commented Jun 2, 2024

Copy link
Copy Markdown
Contributor

So, do we need to always set DOCKER_HOST now, even for docker?
This might need a change to script then

@igagis

igagis commented Jun 2, 2024

Copy link
Copy Markdown
Contributor

Or... I'm confused

@ChristopherHX

Copy link
Copy Markdown
Owner Author

So, do we need to always set DOCKER_HOST now, even for docker?
This might need a change to script then

No, default behavior from 2021 has not been touched.

nektos/act set's the config to /var/run/docker.sock if we don't set it externally to an non empty string, it's pretty deep in the code.

@igagis

igagis commented Jun 2, 2024

Copy link
Copy Markdown
Contributor

Ah, ok, now I got it. Thanks for fast release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants