fix(web): notifications scroll + semantic-empty validation (#723 #726)#747
Merged
Conversation
- #723: NotificationsPage had no own scroll surface; RootLayout's <main> is overflow-hidden, so once the list outgrew the viewport older entries were unreachable. Wrapped body in an h-full overflow-y-auto shell, same pattern UploadSkillPage uses for the same constraint. - #726: ExplorePage now detects mode==="semantic" && empty query and swaps the generic "No skills match" EmptyState for an explicit "Enter a search description" / "Semantic search needs a description of what you're looking for. Type a phrase in the search box above, or switch back to Keyword mode." (with zh translation). Backend queries still fire — they're cheap and cached — but the user sees a clear validation hint instead of a misleading null result. Fixes #723, Fixes #726
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotificationsPagebody wrapped inh-full overflow-y-autoso the list can scroll past viewport height (was clipped by RootLayout'soverflow-hidden).ExplorePageswaps the generic "No skills match" empty state for an explicit "Enter a search description" EmptyState when semantic mode is active with an empty query. Backend 400s become invisible chatter; user sees a validation hint.Test plan
bun run typecheck:webclean/notificationswith > viewport-height of entries → can scroll to oldest row./registry→ switch to Semantic with empty input → see 'Enter a search description' instead of 'No public skills match'.Fixes #723, Fixes #726