Skip to content

Correct failure to mark warning input at f-string#962

Merged
jspeerless merged 1 commit into
mainfrom
bugfix/spt-1504-format-binding
Sep 3, 2024
Merged

Correct failure to mark warning input at f-string#962
jspeerless merged 1 commit into
mainfrom
bugfix/spt-1504-format-binding

Conversation

@kroenlein

Copy link
Copy Markdown
Collaborator

Citrine Python PR

Description

https://citrine.atlassian.net/browse/SPT-1504

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@jspeerless jspeerless left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jspeerless jspeerless merged commit acfbbcb into main Sep 3, 2024
@jspeerless jspeerless deleted the bugfix/spt-1504-format-binding branch September 3, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants