Skip to content

doc update#966

Merged
xperrylinn merged 1 commit into
mainfrom
docs_update
Sep 23, 2024
Merged

doc update#966
xperrylinn merged 1 commit into
mainfrom
docs_update

Conversation

@xperrylinn

Copy link
Copy Markdown
Contributor

Citrine Python PR

Description

Please briefly explain the goal of the changes/this PR.
The reviewer should be able to understand why the change is being made by reading this description
and its links (e.g. JIRA tickets).

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@xperrylinn xperrylinn requested a review from a team as a code owner September 20, 2024 21:17

@anoto-moniz anoto-moniz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine, as I'm assuming you've seen multiple in the wild.

@xperrylinn xperrylinn merged commit 430e889 into main Sep 23, 2024
@xperrylinn xperrylinn deleted the docs_update branch September 23, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants