Skip to content

Speed up DS unit test.#986

Merged
anoto-moniz merged 1 commit into
mainfrom
speed-up-ds-unit-test
Jan 17, 2025
Merged

Speed up DS unit test.#986
anoto-moniz merged 1 commit into
mainfrom
speed-up-ds-unit-test

Conversation

@anoto-moniz

Copy link
Copy Markdown
Collaborator

Have requests in test_design_space_limits return smaller responses, as most of the time was spent building them into objects.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

Have requests in test_design_space_limits return smaller responses, as
most of the time was spent building them into objects.
@anoto-moniz anoto-moniz force-pushed the speed-up-ds-unit-test branch from cb05a09 to 29312b3 Compare January 17, 2025 18:12
@anoto-moniz anoto-moniz marked this pull request as ready for review January 17, 2025 18:15
@anoto-moniz anoto-moniz requested a review from a team as a code owner January 17, 2025 18:15

@kroenlein kroenlein left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dramatically reduces the entropy in this test, but I was always skeptical that we needed that much.

Pulling in numpy would also speed this up (https://numpy.org/doc/stable/reference/random/generated/numpy.random.rand.html), but probably doesn't matter.

@anoto-moniz anoto-moniz merged commit a4b8c92 into main Jan 17, 2025
@anoto-moniz anoto-moniz deleted the speed-up-ds-unit-test branch January 17, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants