Speed up DS unit test.#986
Merged
Merged
Conversation
Have requests in test_design_space_limits return smaller responses, as most of the time was spent building them into objects.
cb05a09 to
29312b3
Compare
kroenlein
approved these changes
Jan 17, 2025
kroenlein
left a comment
Collaborator
There was a problem hiding this comment.
This dramatically reduces the entropy in this test, but I was always skeptical that we needed that much.
Pulling in numpy would also speed this up (https://numpy.org/doc/stable/reference/random/generated/numpy.random.rand.html), but probably doesn't matter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have requests in
test_design_space_limitsreturn smaller responses, as most of the time was spent building them into objects.PR Type:
Adherence to team decisions