A few small fixups#10
Merged
Merged
Conversation
This was missed in ClangBuiltLinux#9. Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
QEMU_RAM's default definition was moved into each switch case to appease shellcheck, which complained about a default assignment parameter expanstion. We can avoid both the warning and the duplication by using a regular '-z' check before QEMU_RAM is actually used. Link: https://github.com/ClangBuiltLinux/boot-utils/runs/611466476 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
So that people get auto added to review pull requests. Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
nickdesaulniers
approved these changes
Apr 27, 2020
tpimh
approved these changes
Apr 27, 2020
|
Maybe we can also set |
msfjarvis
approved these changes
Apr 27, 2020
msfjarvis
left a comment
msfjarvis
left a comment
Member
There was a problem hiding this comment.
I'm fine being a codeowner here 👍
Member
Author
I'd be fine with this in a follow up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits are pretty self explanatory :)
@msfjarvis @tpimh are you guys okay being code owners for this repo?