Skip to content

ruff.toml: Disable S603 and S607#100

Merged
nathanchance merged 1 commit into
ClangBuiltLinux:mainfrom
nathanchance:disable-new-ruff-flake8-bandit-rules
Apr 20, 2023
Merged

ruff.toml: Disable S603 and S607#100
nathanchance merged 1 commit into
ClangBuiltLinux:mainfrom
nathanchance:disable-new-ruff-flake8-bandit-rules

Conversation

@nathanchance

Copy link
Copy Markdown
Member

Reading the bandit documentation, these warnings are low severity and
it would make the code significantly worse to try and work around them,
so opt out of them. These calls are working as intended and this script
is designed to be used interactively so injection is not a concern.

Link: https://bandit.readthedocs.io/en/latest/plugins/b603_subprocess_without_shell_equals_true.html
Link: https://bandit.readthedocs.io/en/latest/plugins/b607_start_process_with_partial_path.html

Reading the bandit documentation, these warnings are low severity and
it would make the code significantly worse to try and work around them,
so opt out of them. These calls are working as intended and this script
is designed to be used interactively so injection is not a concern.

Link: https://bandit.readthedocs.io/en/latest/plugins/b603_subprocess_without_shell_equals_true.html
Link: https://bandit.readthedocs.io/en/latest/plugins/b607_start_process_with_partial_path.html
Signed-off-by: Nathan Chancellor <nathan@kernel.org>

@nickdesaulniers nickdesaulniers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks! 🇮🇪 🍀

@nathanchance nathanchance merged commit 848054c into ClangBuiltLinux:main Apr 20, 2023
@nathanchance nathanchance deleted the disable-new-ruff-flake8-bandit-rules branch April 20, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants