utils.py: Do not query GitHub's API at all with '--gh-json-file'#113
Merged
nathanchance merged 1 commit intoAug 21, 2023
Conversation
Occasionally, I have noticed the occasional failure to query GitHub's rate limit API for various reasons, even when providing an up to date release JSON file via '--gh-json-file'. A rate limit query is unneeded in this instance because we are not going to query GitHub's API for the latest release information, as it has already been provided to us by the user. Restructure the code so that the rate limit API is only queried when we will actually need to query the API for the latest release. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
msfjarvis
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occasionally, I have noticed the occasional failure to query GitHub's
rate limit API for various reasons, even when providing an up to date
release JSON file via '--gh-json-file'. A rate limit query is unneeded
in this instance because we are not going to query GitHub's API for the
latest release information, as it has already been provided to us by the
user.
Restructure the code so that the rate limit API is only queried when we
will actually need to query the API for the latest release.