Skip to content

qemu: aarch64: switch to -cpu max for PAC/BTI#20

Merged
nickdesaulniers merged 1 commit into
masterfrom
aarch64_cpu_all
Jun 16, 2020
Merged

qemu: aarch64: switch to -cpu max for PAC/BTI#20
nickdesaulniers merged 1 commit into
masterfrom
aarch64_cpu_all

Conversation

@nickdesaulniers

Copy link
Copy Markdown
Member

The PAC/BTI instructions were added in v8.3a/v8.5a.
(See https://reviews.llvm.org/D62609).
Without enabling this cpu, the instructions are treated as NOPS. Switch
to a CPU that will use these instructions, testing kernel configs
(CONFIG_ARM64_PTR_AUTH, CONFIG_ARM64_BTI) which we will ship and
Android+CrOS as soon as hardware is available.

Suggested-by: Mark Brown broonie@kernel.org

The PAC/BTI instructions were added in v8.3a/v8.5a.
(See https://reviews.llvm.org/D62609).
Without enabling this cpu, the instructions are treated as NOPS.  Switch
to a CPU that will use these instructions, testing kernel configs
(CONFIG_ARM64_PTR_AUTH, CONFIG_ARM64_BTI) which we will ship and
Android+CrOS as soon as hardware is available.

Suggested-by: Mark Brown <broonie@kernel.org>

@nathanchance nathanchance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@nickdesaulniers nickdesaulniers merged commit 7872af7 into master Jun 16, 2020
@nickdesaulniers nickdesaulniers deleted the aarch64_cpu_all branch June 16, 2020 18:33
@nickdesaulniers

Copy link
Copy Markdown
Member Author

thanks for the reviews!

nickdesaulniers added a commit to ClangBuiltLinux/continuous-integration that referenced this pull request Jun 22, 2020
Changing -cpu to max in
ClangBuiltLinux/boot-utils#20
for PAC+BTI emulation seems to have slowed our boot tests down.

Fixes: https://github.com/ClangBuiltLinux/linux/issues/1058
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants