gdb: require gdb-multiarch for -g#21
Merged
Merged
Conversation
Member
|
|
Member
Author
diff --git a/boot-qemu.sh b/boot-qemu.sh
index 3b760dc5ae89..8511d86486c3 100755
--- a/boot-qemu.sh
+++ b/boot-qemu.sh
@@ -227,7 +227,9 @@ function invoke_qemu() {
-s -S &
QEMU_PID=$!
green "Starting GDB..."
- gdb-multiarch "${KBUILD_DIR}/vmlinux" -ex "target remote :1234"
+ set -x
+ "${GDB:-gdb-multiarch}" "${KBUILD_DIR}/vmlinux" -ex "target remote :1234"
+ set +x
red "Killing QEMU..."
kill -9 "${QEMU_PID}"
wait "${QEMU_PID}" 2>/dev/nullseems to expand to am I holding it wrong? |
Member
Author
|
ah, right cause we have a local |
Since `gdb` likely was only configured for the those triple.
41e164b to
97b5266
Compare
nathanchance
approved these changes
Jun 16, 2020
nathanchance
left a comment
Member
There was a problem hiding this comment.
That works. I was going to suggest changing the current GDB to USE_GDB to work around it but this works too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
gdblikely was only configured for the those triple.