boot-qemu.sh: Expect uImage for ppc32#22
Merged
nickdesaulniers merged 1 commit intoJun 17, 2020
Conversation
zImage has always been a hardlink to uImage but as of a refactoring in 5.8-rc1, that is no longer guaranteed to be the case. Explicitly use the uImage, which will always work for QEMU. Link: https://lore.kernel.org/linuxppc-dev/87bllidmk4.fsf@mpe.ellerman.id.au/ Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
msfjarvis
approved these changes
Jun 17, 2020
nickdesaulniers
approved these changes
Jun 17, 2020
nickdesaulniers
left a comment
nickdesaulniers
left a comment
Member
There was a problem hiding this comment.
thanks, did you test this? MPE didn't get back to me yet on my inquiry (and I'm too lazy to test, myself) 🍺
Member
Author
|
I did and it worked fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zImage has always been a hardlink to uImage but as of a refactoring in
5.8-rc1, that is no longer guaranteed to be the case. Explicitly use the
uImage, which will always work for QEMU.
Link: https://lore.kernel.org/linuxppc-dev/87bllidmk4.fsf@mpe.ellerman.id.au/