boot-qemu.sh: Add '-nodefaults' to ppc64le command line#3
Merged
Merged
Conversation
An upcoming QEMU change will make it so that the bmc devices are created automatically. Unfortunately, that breaks our command line with the following cryptic error: qemu-system-ppc64: error creating device tree: node: FDT_ERR_EXISTS The author of the patch changed it so that the devices are only created when '-nodefaults' is not set (i.e. using defaults). Add this flag to our QEMU command line so that this command line continues to work for all QEMU versions. Tested locally with 3.1.0 (the version in Debian stable), 4.2.0 (current QEMU stable), and 5.0.0-rc1 (latest QEMU -rc). Link: https://lore.kernel.org/qemu-devel/20200404071707.GA24708@ubuntu-m2-xlarge-x86/ Link: https://lore.kernel.org/qemu-devel/20200404153655.166834-1-clg@kaod.org/ Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
nickdesaulniers
approved these changes
Apr 7, 2020
nickdesaulniers
left a comment
nickdesaulniers
left a comment
Member
There was a problem hiding this comment.
I think @adelva1984 mentioned that this flag might be of interest for all invocations of QEMU.
Member
Author
|
I'll start with this then test Thanks for the note and review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An upcoming QEMU change will make it so that the bmc devices are created
automatically. Unfortunately, that breaks our command line with the
following cryptic error:
qemu-system-ppc64: error creating device tree: node: FDT_ERR_EXISTS
The author of the patch changed it so that the devices are only created
when '-nodefaults' is not set (i.e. using defaults). Add this flag to
our QEMU command line so that this command line continues to work for
all QEMU versions. Tested locally with 3.1.0 (the version in Debian
stable), 4.2.0 (current QEMU stable), and 5.0.0-rc1 (latest QEMU -rc).
Link: https://lore.kernel.org/qemu-devel/20200404071707.GA24708@ubuntu-m2-xlarge-x86/
Link: https://lore.kernel.org/qemu-devel/20200404153655.166834-1-clg@kaod.org/