Fix finding the dtb after the kernel image location refactoring#30
Merged
Conversation
KBUILD_DIR is no longer defined, meaning we look for the required dtb in /arch/arm/boot/dts, which obviously does not exist. Do something similar for dtbs like the kernel image, where we look for either a dts (kbuild output) or dtbs (tuxmake output) folder and error if it cannot be found in either location. Fixes: cc703a8 ("boot-qemu.sh: Allow the user to supply a kernel image directly") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
There is no point in decompressing the rootfs before we make sure that
the kernel image and dtb can be found. Break this function apart because
we need to know the image location before ${ARCH} is reassigned but we
can decompress the image once we know we are actually going to call the
QEMU binary.
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit has the full details in the commit message.
The second one is a small quality of life change that I noticed while debugging this.