boot-utils: Add RISC-V to use '--use-cbl-qemu'#33
Merged
nathanchance merged 1 commit intoFeb 5, 2021
Conversation
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
nickdesaulniers
approved these changes
Feb 5, 2021
Comment on lines
+233
to
+234
| [[ -d ${QEMU_BINARIES} ]] || git clone https://github.com/ClangBuiltLinux/qemu-binaries "${QEMU_BINARIES}" | ||
| git -C "${QEMU_BINARIES}" pull --rebase |
Member
There was a problem hiding this comment.
consider shallow clone and git reset --hard FETCH_HEAD? Though probably overkill as we only have like 2 commits in that repo...it is of binaries though.
Member
Author
|
Yes, I can double back to shallow cloning in the future. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of resolving ClangBuiltLinux/continuous-integration2#72