buildroot: Check init.d action to avoid double version print out#42
Merged
Merged
Conversation
Currently, when booting the images, the version string prints out twice. This is because these scripts are called twice: once with the "start" action and again with the "stop" action. To avoid this, just run the contents of the script when the service is starting. Closes: ClangBuiltLinux#41 Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
msfjarvis
approved these changes
Apr 7, 2021
Member
|
Thanks and thanks @shenki for pointing this out! 🥥 ⛳ |
nickdesaulniers
approved these changes
Apr 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when booting the images, the version string prints out twice.
This is because these scripts are called twice: once with the "start"
action and again with the "stop" action.
To avoid this, just run the contents of the script when the service is
starting.
Given that this is a purely cosmetic issue, I do not think that it is
worth rebuilding the images over.
Closes: #41