boot-qemu.sh: Use stdbuf instead of unbuffer#49
Merged
Merged
Conversation
To avoid needing the "expect" package, use "stdbuf" from coreutils to control output buffering. While at it, switch to line-buffering to avoid stdout/stderr mixing.
kees
requested review from
msfjarvis,
nathanchance,
nickdesaulniers and
tpimh
as code owners
nickdesaulniers
approved these changes
Sep 21, 2021
Contributor
Author
Yeah, I wasn't sure what the correct order of operations should be here, given the separate git trees. |
Member
It is up to you. We can merge the boot-utils pull request then either update the submodule and |
nathanchance
approved these changes
Sep 21, 2021
nathanchance
left a comment
nathanchance
left a comment
Member
There was a problem hiding this comment.
Ah, I thought I was commenting on the continuous-integration2 one, helps to pay attention :^)
LGTM from my tests.
nickdesaulniers
added a commit
to ClangBuiltLinux/continuous-integration2
that referenced
this pull request
Sep 21, 2021
After ClangBuiltLinux/boot-utils#49 we use stdbuf from coreutils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid needing the "expect" package, use "stdbuf" from coreutils to control output buffering. While at it, switch to line-buffering to avoid stdout/stderr mixing.