boot-qemu.sh: Do not set '-cpu' for 32-bit x86#56
Merged
Conversation
This causes warnings when using TCG (i.e. no KVM): qemu-system-i386: warning: TCG doesn't support requested feature: CPUID.80000001H:EDX.syscall [bit 11] qemu-system-i386: warning: TCG doesn't support requested feature: CPUID.80000001H:EDX.lm [bit 29] The '-cpu' flag was added to support using prebuilt GCC toolchains in Buildroot in commit 344ff00 ("boot-qemu.sh: Use Nehalem for non-KVM boot on x86_64") but I forgot that this block applies to both 32-bit and 64-bit x86. Given that Nehalem is a 64-bit microarchitecture, this flag should only be supplied when booting an x86_64 kernel, which removes the warning for "-a x86". Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
msfjarvis
approved these changes
Mar 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes warnings when using TCG (i.e. no KVM):
The '-cpu' flag was added to support using prebuilt GCC toolchains in
Buildroot in commit 344ff00 ("boot-qemu.sh: Use Nehalem for non-KVM boot
on x86_64") but I forgot that this block applies to both 32-bit and
64-bit x86.
Given that Nehalem is a 64-bit microarchitecture, this flag should only
be supplied when booting an x86_64 kernel, which removes the warning for
-a x86.