boot-qemu.py: Combine aarch64 machine flags#77
Merged
nathanchance merged 1 commit intoNov 20, 2022
Merged
Conversation
Two '-machine' arguments looks odd, especially since the gic-version parameter is specified on the first '-machine' instance. Append 'virtualization=true' to the existing machine string in a similar manner to 'gic-version' to keep everything uniform. Additionally, add a comment around why and where 'virtualization=true' is specified. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
msfjarvis
approved these changes
Nov 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
-machinearguments looks odd, especially since thegic-versionparameter is specified on the first
-machineinstance.Append
virtualization=trueto the existing machine string in a similarmanner to
gic-versionto keep everything uniform. Additionally, add acomment around why and where
virtualization=trueis specified.