boot-qemu.py: Use tuples for Linux and QEMU versions#78
Merged
nathanchance merged 1 commit intoDec 2, 2022
Merged
Conversation
There is no reason to roll our own versioning format when we can
automatically generate tuples for the versions to allow more natural and
obvious comparisons, similar to sys_version_info. For example:
if qemu_ver_code < 602050:
vs.
if qemu_ver < (6, 2, 50):
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no reason to roll our own versioning format when we can
automatically generate tuples for the versions to allow more natural and
obvious comparisons, similar to
sys.version_info. For example:vs.