boot-utils: Fix new pylint warnings#89
Merged
Merged
Conversation
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
New pylint warns: boot-qemu.py:401:12: W0719: Raising too general exception: Exception (broad-exception-raised) boot-qemu.py:431:16: W0719: Raising too general exception: Exception (broad-exception-raised) The type of exception really does not matter, as we do not expect this script to be called, so the exception will never be caught. However, it is easy to silence this by switching to a more specific exception. FileNotFoundError is descriptive so use this exception to silence the warning. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
New pylint warns: boot-qemu.py:413:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) boot-qemu.py:418:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) We do not expect these calls to fail but the refactoring is simple to silence the warning. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
force-pushed
the
new-pylint
branch
from
f7005b9 to
0709eae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of fixes for new pylint. See each change for the full warning and details.