This repository was archived by the owner on Apr 13, 2024. It is now read-only.
enable llvm-ar by default#127
Merged
Merged
Conversation
Member
|
Looks sane to me. There were no kernel patches needed right? I only ask because we're building back to 4.4. |
Member
Author
|
I don't think so. We could do a presubmit run; but I think it's ok to let it fail in postsubmit tonight and clean up tomorrow. WDYT? |
Member
|
Sounds good to me. I am doing a run of linux-next builds on my box right now; once that is done, I'll do some tests locally and report back. |
nathanchance
approved these changes
Mar 6, 2019
nathanchance
left a comment
nathanchance
left a comment
Member
There was a problem hiding this comment.
This appears to work on all stable branches from a few local tests. LGTM, we can triage tomorrow as necessary.
Member
Author
|
thanks for the review. Will look into getting this turned on for Pixel kernels if everything is green (llvm-ar is already used in userspace). |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.