This repository was archived by the owner on Apr 13, 2024. It is now read-only.
enable llvm-size by default for all arch's#211
Merged
Merged
Conversation
Member
Author
|
probably should update usage.txt |
nathanchance
suggested changes
Oct 4, 2019
nathanchance
left a comment
nathanchance
left a comment
Member
There was a problem hiding this comment.
Should probably not update the arm64 rootfs.
git checkout HEAD^ -- images && git commit --amend
should fix that up.
Other than that, I don't really mind the change overall but given that we aren't testing s390 because of #152, seems like unnecessary churn but it's fine given that it is already done.
10 tasks
though it's only used on s390
Member
Author
|
done; yes, it's pointless, but it's one less thing in the Makefile for me to worry about. |
nathanchance
reviewed
Oct 4, 2019
nathanchance
approved these changes
Oct 4, 2019
nathanchance
left a comment
nathanchance
left a comment
Member
There was a problem hiding this comment.
Other than my one nit, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
though it's only used on s390