This repository was archived by the owner on Apr 13, 2024. It is now read-only.
selectively re-enable llvm-objcopy#212
Closed
nickdesaulniers wants to merge 1 commit into
Closed
Conversation
just for arm64, back to LTS 4.9. 4.4 is still broken: #183 (comment) Previously reverted in 684262f ClangBuiltLinux/linux#480 #164
nathanchance
reviewed
Oct 4, 2019
nathanchance
left a comment
nathanchance
left a comment
Member
There was a problem hiding this comment.
I wonder if it would be better to hoist this into driver.sh. As far as I am aware, only 4.4 needs GNU objcopy so that could probably be done with:
case ${REPO} in
*4.4) OBJCOPY=${CROSS_COMPILE:-}objcopy ;;
*)
if [[ -z "${OBJCOPY:-}" ]]; then
for OBJCOPY in $(gen_bin_list llvm-objcopy) llvm-objcopy "${CROSS_COMPILE:-}"objcopy; do
command -v ${OBJCOPY} 2>/dev/null && break
done
fi ;;
esac
I am down with whatever as long as it works though. Given that I do not see any presubmit testing, I assume that was done locally?
10 tasks
Contributor
|
What about llvm-strip? Does it still have problems on arm64? It makes sense to add both objcopy and strip in a single pull-request. |
nathanchance
added a commit
to nathanchance/continuous-integration
that referenced
this pull request
Apr 2, 2020
except for s390, which does not appear to have any support for it in the LLVM tools. Tested locally with build-all.sh. [skip ci] Closes: ClangBuiltLinux#212 Closes: ClangBuiltLinux#249 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just for arm64, back to LTS 4.9.
4.4 is still broken:
#183 (comment)
Previously reverted in 684262f
ClangBuiltLinux/linux#480
#164