This repository was archived by the owner on Apr 13, 2024. It is now read-only.
debian-setup: Install clang-8, lld-8 and llvm-8 with --no-install-rec…#67
Merged
Conversation
…ommends option Check via: $ apt-get install clang-8 lld-8 -t llvm-toolchain -s $ apt-get install clang-8 lld-8 llvm-8 --no-install-recommends -t llvm-toolchain -s CC: Nick Desaulniers <ndesaulniers@google.com> CC: Nathan Chancellor <natechancellor@gmail.com> Suggested-by: Sylvestre Ledru <sylvestre@debian.org> Signed-off-by: Sedat Dilek <sedat.dilek@credativ.de>
nathanchance
approved these changes
Nov 20, 2018
nathanchance
left a comment
Member
There was a problem hiding this comment.
Seems reasonable. I'm testing the same change on all apt-get install commands in the Dockerfile to see how much it slims up the image: https://travis-ci.com/nathanchance/dockerimage/builds/92048750
Member
|
Holy moly ClangBuiltLinux/dockerimage@23d6973 https://hub.docker.com/r/nathanchance/cbl/tags/ https://hub.docker.com/r/clangbuiltlinux/debian/tags/ I'll run some tests now to see if anything is broken but that's a really good change imo. |
Member
Author
|
Want me to wait until you're done testing to merge? If not, please just merge away. |
Member
|
Great to hear this reduces the image sizes.
Not sure if this is a wise and equivalent replacement...
[ /etc/apt/apt.conf or better /etc/apt/apt.conf.d/01norecommend]
APT::Install-Recommends "false";
The man-page of apt-get says:
All command line options may be set using the configuration
file, the descriptions indicate the configuration option to set. For
boolean options you can override the config file by using something
like -f-,--no-f, -f=no or
several other variations.
…--no-install-recommends
Do not consider recommended packages as a dependency for
installing. Configuration Item: APT::Install-Recommends.
Don't know if you can put a list of package-names explicitly as the
above setting is active for all 'apt-get install <pkgname>'
operations.
Bonne chance,
- sed@ -
On Tue, Nov 20, 2018 at 9:58 PM Nathan Chancellor ***@***.***> wrote:
This can go in now, I've locally rebased #62
<#62> on
top of this and have made the changes to the Dockerfile, which I will push
for a pull here soon. Going to post an update on #62
<#62>
shortly.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#67 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAsJyPFgvXp8sziPeZqiN8ZV3e9GHD6mks5uxGz3gaJpZM4YrmR3>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ommends option
Check via:
$ apt-get install clang-8 lld-8 -t llvm-toolchain -s
$ apt-get install clang-8 lld-8 llvm-8 --no-install-recommends -t llvm-toolchain -s
CC: Nick Desaulniers
CC: Nathan Chancellor
Suggested-by: Sylvestre Ledru
Signed-off-by: Sedat Dilek