Skip to content
This repository was archived by the owner on Apr 13, 2024. It is now read-only.

debian-setup: Install clang-8, lld-8 and llvm-8 with --no-install-rec…#67

Merged
nathanchance merged 1 commit into
masterfrom
sedat
Nov 20, 2018
Merged

debian-setup: Install clang-8, lld-8 and llvm-8 with --no-install-rec…#67
nathanchance merged 1 commit into
masterfrom
sedat

Conversation

@nickdesaulniers

Copy link
Copy Markdown
Member

…ommends option

Check via:

$ apt-get install clang-8 lld-8 -t llvm-toolchain -s

$ apt-get install clang-8 lld-8 llvm-8 --no-install-recommends -t llvm-toolchain -s

CC: Nick Desaulniers
CC: Nathan Chancellor
Suggested-by: Sylvestre Ledru
Signed-off-by: Sedat Dilek

…ommends option

Check via:

$ apt-get install clang-8 lld-8 -t llvm-toolchain -s

$ apt-get install clang-8 lld-8 llvm-8 --no-install-recommends -t llvm-toolchain -s

CC: Nick Desaulniers <ndesaulniers@google.com>
CC: Nathan Chancellor <natechancellor@gmail.com>
Suggested-by: Sylvestre Ledru <sylvestre@debian.org>
Signed-off-by: Sedat Dilek <sedat.dilek@credativ.de>

@nathanchance nathanchance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. I'm testing the same change on all apt-get install commands in the Dockerfile to see how much it slims up the image: https://travis-ci.com/nathanchance/dockerimage/builds/92048750

@nathanchance

Copy link
Copy Markdown
Member

Holy moly --no-install-recommends cut the size of the image down by 50%...

ClangBuiltLinux/dockerimage@23d6973

https://hub.docker.com/r/nathanchance/cbl/tags/

https://hub.docker.com/r/clangbuiltlinux/debian/tags/

I'll run some tests now to see if anything is broken but that's a really good change imo.

@nickdesaulniers

Copy link
Copy Markdown
Member Author

Want me to wait until you're done testing to merge? If not, please just merge away.

@nathanchance

Copy link
Copy Markdown
Member

This can go in now, I've locally rebased #62 on top of this and have made the changes to the Dockerfile, which I will push for a pull here soon. Going to post an update on #62 shortly.

@nathanchance nathanchance merged commit 19823ae into master Nov 20, 2018
@nathanchance nathanchance deleted the sedat branch November 20, 2018 20:58
@dileks

dileks commented Nov 21, 2018 via email

Copy link
Copy Markdown

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants