Enable booting MIPS and PowerPC kernels by nathanchance · Pull Request #73 · ClangBuiltLinux/continuous-integration2

nathanchance · 2021-02-04T22:22:04Z

I will rebase this on #71 after it is merged but I wanted to get ahead of this for review.

TuxSuite has merged support for kernel_image so we can add that to generator.yml for architectures that need it.

Closes: #1
Closes: #27

nathanchance · 2021-02-05T00:25:18Z

I do have RISC-V working already (#72), which I can combine into this pull if it is desirable. Alternatively, we merge this and enable RISC-V in a separate pull.

nickdesaulniers

Let's keep the riscv changes distinct for now.

nickdesaulniers · 2021-02-05T01:18:53Z

+  - {<< : *ppc32,      << : *mainline,         << : *llvm,            boot: true,  llvm_version: *llvm_tot}
+  - {<< : *ppc64,      << : *mainline,         << : *ppc64_llvm,      boot: true,  llvm_version: *llvm_tot}
+  - {<< : *ppc64le,    << : *mainline,         << : *llvm,            boot: true,  llvm_version: *llvm_tot}
+  - {<< : *riscv,      << : *mainline,         << : *riscv_llvm_full, boot: true,  llvm_version: *llvm_tot}


will this depend on the riscv qemu changes?

(looks like yes)

Yes. See my other comment for why it might be advantageous to just enable booting RISC-V with this pull.

nickdesaulniers · 2021-02-05T01:19:26Z

+  - &ppc64le    {config: powernv_defconfig,                            kernel_image: zImage.epapr, << : *powerpc64le-triple,   << : *kernel_modules}
  #                                  https://github.com/ClangBuiltLinux/linux/issues/1143
-  - &riscv      {config: [defconfig, CONFIG_EFI=n],                    << : *riscv-triple,         << : *kernel_modules}
+  - &riscv      {config: [defconfig, CONFIG_EFI=n],                    kernel_image: Image, << : *riscv-triple,         << : *kernel_modules}


Does specifying a kernel_image to tuxsuite prevent the kernel modules from being built? (We don't want that; we want to build the kernel modules). cc @danrue @terceiro

No. The modules are a separate target and we always build those.

nickdesaulniers · 2021-02-05T01:20:56Z

  - {<< : *ppc64le,    << : *next,             << : *llvm,            boot: true,  llvm_version: *llvm_latest}
-  - {<< : *riscv,      << : *next,             << : *riscv_llvm_full, boot: true,  llvm_version: *llvm_latest}
+  # riscv: Boot disabled (https://github.com/ClangBuiltLinux/continuous-integration2/issues/72)
+  - {<< : *riscv,      << : *next,             << : *riscv_llvm_full, boot: false, llvm_version: *llvm_latest}


maybe fold this commit into the one that enabled it? (Should be straightforward via interactive rebase)

The reason I did a separate commit was so that it was easy to revert when we wanted to re-enable RISC-V. Now that qemu-binaries and boot-utils have had their pulls merged, I could just update check_logs.py to have --use-cbl-qemu like I suggested in #72 and avoid disabling the builds altogether.

sure, so one more commit on top then?

Yes, basically :P

Please see https://github.com/nathanchance/continuous-integration2/commits/image-targets-with-riscv for what it would look like. If you think that is okay, I will push it under this branch so that the pull updates.

nickdesaulniers · 2021-02-05T01:21:34Z

        "x86_64": ["qemu-system-x86"],
        "s390": [],
-        "riscv": ["qemu-system-riscv64"],
+        "riscv": ["opensbi", "qemu-system-riscv64"],


this should wait until we enable riscv, separately.

nickdesaulniers · 2021-02-05T01:23:19Z

I found it much easier to review multiple smaller commits in github's UI; thank for you for breaking up commits into smaller concerns.

nathanchance · 2021-02-05T01:34:02Z

I found it much easier to review multiple smaller commits in github's UI; thank for you for breaking up commits into smaller concerns.

Good! I will continue to do this in the future.

malta_kvm_guest_defconfig is a little endian configuration. If we want it to be big endian, we need to pass CONFIG_CPU_BIG_ENDIAN, which we can then use to set the right CBL architecture. Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Link: https://gitlab.com/Linaro/tuxsuite/-/merge_requests/95 Signed-off-by: Nathan Chancellor <nathan@kernel.org>

…name Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

We are not using Ubuntu's QEMU right now so there is not much point to installing it. Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

i386 is still broken with clang-12 and newer. Certain powerpc builds are still broken with tuxmake and older versions of clang. Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Certain powerpc builds are still broken with tuxmake and older versions of clang. Signed-off-by: Nathan Chancellor <nathan@kernel.org>

i386 is still broken with clang-12 and newer. Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

nathanchance · 2021-02-05T02:35:55Z

Sigh that is not what I meant to do...

nickdesaulniers

nice, this gets us back to parity with all arches now, right? 🧇 🍟

nathanchance · 2021-02-05T03:11:39Z

Yes, all of the architectures should boot if they can build :)

nathanchance · 2021-02-05T03:11:48Z

Thanks for the review!

nathanchance requested a review from nickdesaulniers February 4, 2021 22:22

nathanchance force-pushed the image-targets branch from baa7336 to b472f9f Compare February 4, 2021 22:47

nathanchance mentioned this pull request Feb 5, 2021

ci2: Add all*config builds #75

Merged

nickdesaulniers requested changes Feb 5, 2021

View reviewed changes

nathanchance added 17 commits February 4, 2021 18:42

utils.py: Properly support big-endian MIPS

61fff8b

malta_kvm_guest_defconfig is a little endian configuration. If we want it to be big endian, we need to pass CONFIG_CPU_BIG_ENDIAN, which we can then use to set the right CBL architecture. Signed-off-by: Nathan Chancellor <nathan@kernel.org>

generator.yml: Add CONFIG_CPU_BIG_ENDIAN=y to mips config

1ddd9e2

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

generate_tuxsuite.py: Add support for kernel_image

e384ed1

Link: https://gitlab.com/Linaro/tuxsuite/-/merge_requests/95 Signed-off-by: Nathan Chancellor <nathan@kernel.org>

utils.py: Add proper support for PowerPC images and fix RISC-V image …

a5caf73

…name Signed-off-by: Nathan Chancellor <nathan@kernel.org>

boot-utils: Update to latest main

f138acd

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

check_logs.py: Allow RISC-V to use '--use-cbl-qemu'

4dee8ae

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

install_deps.py: Do not install qemu-system-riscv64

d50a998

We are not using Ubuntu's QEMU right now so there is not much point to installing it. Signed-off-by: Nathan Chancellor <nathan@kernel.org>

generator.yml: Add kernel_image where necessary

9317e50

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

generator.yml: Realign defconfigs section

16967c2

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

tuxsuite: Regenerate files

6f72ae0

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

generator.yml: Build and boot most architectures on mainline

f2a7d1f

i386 is still broken with clang-12 and newer. Certain powerpc builds are still broken with tuxmake and older versions of clang. Signed-off-by: Nathan Chancellor <nathan@kernel.org>

generator.yml: Build and boot most architectures on next

7da25b7

Certain powerpc builds are still broken with tuxmake and older versions of clang. Signed-off-by: Nathan Chancellor <nathan@kernel.org>

generator.yml: Build and boot most architectures on 5.10

6e662af

i386 is still broken with clang-12 and newer. Signed-off-by: Nathan Chancellor <nathan@kernel.org>

generator.yml: Build and boot all architectures on 5.4

f4093c1

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

generator.yml: Build and boot all architectures on 4.19

f442762

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

generator.yml: Build and boot all architectures on 4.14

211b7ee

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

ci2: Regenerate TuxSuite and workflow files

df1c60a

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

nathanchance force-pushed the image-targets branch from b472f9f to df1c60a Compare February 5, 2021 02:33

nathanchance closed this Feb 5, 2021

nathanchance deleted the image-targets branch February 5, 2021 02:33

nathanchance restored the image-targets branch February 5, 2021 02:35

nathanchance reopened this Feb 5, 2021

nickdesaulniers approved these changes Feb 5, 2021

View reviewed changes

nathanchance merged commit f17b058 into ClangBuiltLinux:main Feb 5, 2021

nathanchance deleted the image-targets branch February 5, 2021 03:12

nathanchance linked an issue Feb 5, 2021 that may be closed by this pull request

RISC-V needs a newer version of QEMU #72

Closed

Conversation

nathanchance commented Feb 4, 2021

Uh oh!

nathanchance commented Feb 5, 2021

Uh oh!

nickdesaulniers left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickdesaulniers commented Feb 5, 2021

Uh oh!

nathanchance commented Feb 5, 2021

Uh oh!

nathanchance commented Feb 5, 2021

Uh oh!

nickdesaulniers left a comment

Choose a reason for hiding this comment

Uh oh!

nathanchance commented Feb 5, 2021

Uh oh!

nathanchance commented Feb 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants