task(SDK-4685) - Dark mode for push templates#45
Merged
Conversation
Contributor
kushCT
commented
May 19, 2025
kushCT
commented
- Adds dark mode support for push templates
- Removes bg as mandatory key
- Parses colour based on dark mode of phone
Release v0.2.7
Release v0.3.0
… light/dark mode without rendering again
- Updated podspec - Updated SPM project to support dark mode templates - Updated xcframework
kushCT
requested review from
Sonal-Kachare,
akashvercetti,
nishant-clevertap and
nzagorchev
added 7 commits
June 3, 2025 12:41
Updated xcframework
Contributor
nishant-clevertap
left a comment
nishant-clevertap
left a comment
There was a problem hiding this comment.
@kushCT Add the new keys in Readme file also for every templates, and if possible add screenshots for dark mode also.
Contributor
nishant-clevertap
left a comment
nishant-clevertap
left a comment
There was a problem hiding this comment.
We should not commit the simulator and device frameworks folder generated for creating xcframework. @akashvercetti Can you confirm this? If Yes, remove those folders
Contributor
Author
|
Contributor
|
archive files are not needed |
nishant-clevertap
requested changes
Jun 10, 2025
…raitChanges for iOS 17+ and falling back to the overridden method for iOS <17
nishant-clevertap
requested changes
Jun 10, 2025
- Fixes dark mode text colors when images are tapped. - Fixes registerForTraitChanges for iOS 17 and above
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
akashvercetti
approved these changes
Jun 18, 2025
akashvercetti
approved these changes
Jun 20, 2025
Contributor
akashvercetti
left a comment
akashvercetti
left a comment
There was a problem hiding this comment.
tested on spm. looks fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.