Skip to content

fix:ipv4 column append problem#101

Closed
ghost wants to merge 2 commits into
masterfrom
unknown repository
Closed

fix:ipv4 column append problem#101
ghost wants to merge 2 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Aug 26, 2021

Copy link
Copy Markdown

#88 fix:ipv4 column append problem.author: BozaB.

@BozaB

BozaB commented Sep 16, 2021

Copy link
Copy Markdown

Hellozhuzhu, thank you! :)

@filimonov

Copy link
Copy Markdown
Contributor

Great, can you also add the problematic ip to the test?

v4->Append("127.0.0.1");

@ghost

ghost commented Sep 18, 2021

Copy link
Copy Markdown
Author

Of course.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


BozaB seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Enmk Enmk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign CLA and write some unit tests, simple/main.cpp is not built/run in CI/CD

@Enmk Enmk mentioned this pull request Feb 2, 2022
@Enmk Enmk closed this in #148 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants