Support Date32 data type.

[huyphams]

• Added date32 (Which is 4 bytes when compared with 2 byte Date).

[CLAassistant]

All committers have signed the CLA.

[huyphams]

I think I should add a test for Date32

[Enmk]

I think I should add a test for Date32

Hi, thank you for contribution!

Yes, please add some tests. There are two kinds of them:

• unit-tests (ut/columns_ut.cpp), where one should test APIs of Column: creating, appending, getting values, slicing, etc.
• integration-tests (ut/client_ut.cpp), where one should test roundtrip of Column data to/from CH server.

If you find it difficult adding both, please add at least something and allow edit from maintainers in this PR.

[Enmk]

Please move the new value to the end. This is enum is visible to users and some may rely on order of elements. I think we can re-arrange those to look better in a next major version, like 3.0

[huyphams]

Done

[Enmk]

Please fix minor issue mentioned

[huyphams]

Thank you for reviewing, I will fix it 🙌

[Enmk]

Please rebase/merge master and fix the builds

[huyphams]

Hi @Enmk I've merged master into this branch. Could you help me to write the test (if you have time)? 🙌

[Enmk]

Hi @Enmk I've merged master into this branch. Could you help me to write the test (if you have time)? raised_hands

Sure, I've drafted a scaffold for unit-testing Column implementation. Will try to finalize and commit it on Monday.

[Enmk]

Hi @Enmk I've merged master into this branch. Could you help me to write the test (if you have time)? raised_hands

Hello @huyphams !
It took a bit more time to iron everything out, but it is almost ready now:
Once #179 is merged, you can use a test suite to verify that column correctly implements most of the expected methods.

In order to benefit form test suite, you'll need to make some changes to the ut/Column_ut.cpp:

• add ColumnDateTime32 to the type-list using ValueColumns = ::testing::Types<
• add meaningful value generator to static auto GenerateValues(size_t values_size) {
• optionally add proper constructor to static auto MakeColumn() {

If you have some very specific test cases, that are not covered by generic test suite, you can add those into ut/coulns_ut.cpp.

Also you are welcome to review the pr #179

[Enmk]

@huyphams ping?