Skip to content

bugfix, remove items_.reserve for batch write #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Enmk merged 2 commits into from
Nov 22, 2022
Merged

bugfix, remove items_.reserve for batch write #248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e76cb29
remove items_.reserve for batch write
1261385937 Nov 19, 2022
69062c9
Minor comment
Enmk Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clickhouse/columns/string.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,8 @@ void ColumnString::Append(ColumnRef column) {
// TODO: fill up existing block with some items and then add a new one for the rest of items
if (blocks_.size() == 0 || blocks_.back().GetAvailable() < total_size)
blocks_.emplace_back(std::max(DEFAULT_BLOCK_SIZE, total_size));
items_.reserve(items_.size() + col->Size());

// Intentionally not doing items_.reserve() since that cripples performance.
for (size_t i = 0; i < column->Size(); ++i) {
this->AppendUnsafe((*col)[i]);
}
Expand Down