Skip to content

Set backward_compatibility_lowcardinality_as_wrapped_column default value to false #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Enmk merged 2 commits into from
Sep 26, 2023
+5 −4
Merged

Set backward_compatibility_lowcardinality_as_wrapped_column default value to false #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f21ba79
Set backward_compatibility_lowcardinality_as_wrapped_column default v…
Enmk Sep 25, 2023
9b2b219
Fixed the tests
Enmk Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clickhouse/client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ struct ClientOptions {
* @see LowCardinalitySerializationAdaptor, CreateColumnByType
*/
[[deprecated("Makes implementation of LC(X) harder and code uglier. Will be removed in next major release (3.0) ")]]
DECLARE_FIELD(backward_compatibility_lowcardinality_as_wrapped_column, bool, SetBakcwardCompatibilityFeatureLowCardinalityAsWrappedColumn, true);
DECLARE_FIELD(backward_compatibility_lowcardinality_as_wrapped_column, bool, SetBakcwardCompatibilityFeatureLowCardinalityAsWrappedColumn, false);

/** Set max size data to compress if compression enabled.
*
Expand Down
7 changes: 4 additions & 3 deletions ut/low_cardinality_nullable_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ TEST(LowCardinalityOfNullable, InsertAndQueryEmpty) {
block.AppendColumn("words", column);

Client client(ClientOptions(localHostEndpoint)
.SetBakcwardCompatibilityFeatureLowCardinalityAsWrappedColumn(false)
.SetPingBeforeQuery(true));
.SetBakcwardCompatibilityFeatureLowCardinalityAsWrappedColumn(false)
.SetPingBeforeQuery(true));

createTable(client);

Expand All @@ -141,7 +141,8 @@ TEST(LowCardinalityOfNullable, ThrowOnBackwardsCompatibleLCColumn) {
block.AppendColumn("words", column);

Client client(ClientOptions(localHostEndpoint)
.SetPingBeforeQuery(true));
.SetPingBeforeQuery(true)
.SetBakcwardCompatibilityFeatureLowCardinalityAsWrappedColumn(true));

createTable(client);

Expand Down