Fix Tool-tip position in Firefox for pie charts#5
Merged
Conversation
added 2 commits
May 21, 2021 10:16
faizaankhan
approved these changes
May 21, 2021
deepaksharma33
approved these changes
May 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue is due to a firefox/d3 bug.
When the transform is applied on the parent card,
d3.mousefunction doesn't return the correct value in firefox.https://bugzilla.mozilla.org/show_bug.cgi?id=1610093
This solution has been based on some workaround suggested here.
d3/d3-selection#81
and d3/d3-selection#191
Basically, function
tooltipPositionoverridden by the copy of the same function with minor change for firefox useragent.