Skip to content

Count sell-outs for a product version#535

Merged
gionn merged 1 commit into
masterfrom
product-version-sellouts
Jul 2, 2020
Merged

Count sell-outs for a product version#535
gionn merged 1 commit into
masterfrom
product-version-sellouts

Conversation

@malteo
Copy link
Copy Markdown
Member

@malteo malteo commented Jul 1, 2020

No description provided.

private long markedUp;

@ApiModelProperty( "The number of sell-outs set for the product version" )
private long soldOut;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the past tense of "sell-out", as markedUp is the past tense of "mark-up"

I read it like "how many versions have been markedUp/soldOut"

@malteo malteo requested a review from gionn July 1, 2020 12:55
@gionn gionn merged commit 072d8a4 into master Jul 2, 2020
@gionn gionn deleted the product-version-sellouts branch July 2, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants