Skip to content

Fix timezone parsing for ISO8601 dates #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gionn merged 1 commit into from
Sep 22, 2021
Merged

Fix timezone parsing for ISO8601 dates #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cloudesire-api-client/src/main/java/com/cloudesire/platform/apiclient/query/OrderQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.cloudesire.platform.apiclient.query;

import com.cloudesire.platform.apiclient.dto.model.enums.OrderType;
import com.cloudesire.platform.apiclient.dto.model.enums.OrderStatus;
import com.cloudesire.platform.apiclient.dto.model.enums.OrderType;
import com.liberologico.cloudesire.common.SimpleDateFormatFactory;

import java.util.Date;
Expand Down Expand Up @@ -47,13 +47,13 @@ public OrderQuery setCoupon( boolean coupon )

public OrderQuery setFrom( Date from )
{
put( FROM, SimpleDateFormatFactory.dateFormat().format( from ) );
put( FROM, SimpleDateFormatFactory.iso8601Format().format( from ) );
return this;
}

public OrderQuery setTo( Date to )
{
put( TO, SimpleDateFormatFactory.dateFormat().format( to ) );
put( TO, SimpleDateFormatFactory.iso8601Format().format( to ) );
return this;
}

Expand Down
2 changes: 1 addition & 1 deletion common-dto/src/main/java/com/liberologico/cloudesire/common/DateFormats.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ public class DateFormats
{
public static final String DATE_PATTERN = "yyyy-MM-dd";
public static final String DATE_TIME_PATTERN = "yyyy-MM-dd HH:mm";
public static final String ISO8601_PATTERN = "yyyy-MM-dd'T'HH:mm:ss.SSSZ";
public static final String ISO8601_PATTERN = "yyyy-MM-dd'T'HH:mm:ss.SSSX";
Copy link
Copy Markdown
Member Author

@malteo malteo Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letter Date or Time Component Presentation Examples
Z Time zone RFC 822 time zone -0800
X Time zone ISO 8601 time zone -08; -0800; -08:00 
    ISO 8601 Time zone:

    ...

    For parsing, "Z" is parsed as the UTC time zone designator.

https://docs.oracle.com/javase/8/docs/api/java/text/SimpleDateFormat.html#iso8601timezone

public static final String SQL_PATTERN = "yyyy-MM-dd HH:mm:ss";

private DateFormats()
Expand Down