Skip to content

FIX #4242 : Travis Build Status to Reflect Deployment Script Failures#4296

Merged
RishabhJain2018 merged 3 commits intoCloud-CV:masterfrom
AishwaryJain07:fix4242
Mar 19, 2025
Merged

FIX #4242 : Travis Build Status to Reflect Deployment Script Failures#4296
RishabhJain2018 merged 3 commits intoCloud-CV:masterfrom
AishwaryJain07:fix4242

Conversation

@AishwaryJain07
Copy link
Copy Markdown
Contributor

closes #4242
Implemented a fix to ensure Travis CI reports failures accurately during deployment.or push script fails!!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.30%. Comparing base (96968d6) to head (d9588e2).
Report is 1121 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4296      +/-   ##
==========================================
- Coverage   72.93%   69.30%   -3.63%     
==========================================
  Files          83       20      -63     
  Lines        5368     3574    -1794     
==========================================
- Hits         3915     2477    -1438     
+ Misses       1453     1097     -356     

see 64 files with indirect coverage changes

see 64 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b8a4a...d9588e2. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AishwaryJain07
Copy link
Copy Markdown
Contributor Author

here i have implemented a || travis_terminate 1;
function to exit with code 1 whenever the code fails.
earlier it was giving exit 0 code even after build not successful, coz there was no condition to check, now i addressed it for both push and deploy

@AishwaryJain07
Copy link
Copy Markdown
Contributor Author

@gchhablani @gautamjajoo @Suryansh5545
can you please review this pr

@AishwaryJain07
Copy link
Copy Markdown
Contributor Author

@Suryansh5545 can you pleaese review it

Copy link
Copy Markdown
Member

@RishabhJain2018 RishabhJain2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@RishabhJain2018 RishabhJain2018 merged commit dab3f1e into Cloud-CV:master Mar 19, 2025
2 of 3 checks passed
RishabhJain2018 added a commit that referenced this pull request Mar 2, 2026
…lures(#4296)

* Fix deployment script failure handling

* added checks for push script

---------

Co-authored-by: Rishabh Jain <rishabhjain2018@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Travis Build Status to Reflect Deployment Script Failures

3 participants