[BugFix] Remove manage worker option#4416
Merged
gchhablani merged 2 commits intoCloud-CV:masterfrom Aug 28, 2024
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4416 +/- ##
==========================================
- Coverage 72.93% 69.30% -3.63%
==========================================
Files 83 20 -63
Lines 5368 3574 -1794
==========================================
- Hits 3915 2477 -1438
+ Misses 1453 1097 -356 see 64 files with indirect coverage changes see 64 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
vaheta
pushed a commit
to vahetag/EvalAI
that referenced
this pull request
Dec 10, 2024
* Remove scale worker option * Remove start/stop
RishabhJain2018
pushed a commit
that referenced
this pull request
Mar 2, 2026
* Remove scale worker option * Remove start/stop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scale worker is incorrect, and does not handle the resources/backend attributes gracefully. Removing it from frontend in this PR.
This feature can be re-added once the issues are fixed.
Similarly, start/stop worker is also problematic.
People start workers initially, and then switch to remote eval without stopping the workers.
These workers have to be manually shut down which consumes credits, and is impractical.
We have auto-scaling, and these users should never need to start/stop/restart things as long as that script works fine.
Also, we are working on auto-deciding the amount of resources to be allocated. Should be added soon, this will handle the scale workers issue.