Skip to content

[BugFix] Remove manage worker option#4416

Merged
gchhablani merged 2 commits intoCloud-CV:masterfrom
gchhablani:remove_scale_worker_option
Aug 28, 2024
Merged

[BugFix] Remove manage worker option#4416
gchhablani merged 2 commits intoCloud-CV:masterfrom
gchhablani:remove_scale_worker_option

Conversation

@gchhablani
Copy link
Copy Markdown
Collaborator

@gchhablani gchhablani commented Aug 28, 2024

Scale worker is incorrect, and does not handle the resources/backend attributes gracefully. Removing it from frontend in this PR.

This feature can be re-added once the issues are fixed.

Similarly, start/stop worker is also problematic.

People start workers initially, and then switch to remote eval without stopping the workers.
These workers have to be manually shut down which consumes credits, and is impractical.

We have auto-scaling, and these users should never need to start/stop/restart things as long as that script works fine.
Also, we are working on auto-deciding the amount of resources to be allocated. Should be added soon, this will handle the scale workers issue.

@gchhablani gchhablani changed the title [BugFix] Remove scale worker option [BugFix] Remove manage worker option Aug 28, 2024
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.30%. Comparing base (96968d6) to head (f2b6141).
Report is 1110 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4416      +/-   ##
==========================================
- Coverage   72.93%   69.30%   -3.63%     
==========================================
  Files          83       20      -63     
  Lines        5368     3574    -1794     
==========================================
- Hits         3915     2477    -1438     
+ Misses       1453     1097     -356     

see 64 files with indirect coverage changes

see 64 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da7e068...f2b6141. Read the comment docs.

@gchhablani gchhablani merged commit 913dd9f into Cloud-CV:master Aug 28, 2024
vaheta pushed a commit to vahetag/EvalAI that referenced this pull request Dec 10, 2024
* Remove scale worker option

* Remove start/stop
RishabhJain2018 pushed a commit that referenced this pull request Mar 2, 2026
* Remove scale worker option

* Remove start/stop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants